Skip to content

Period 29073 #29159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 23, 2019
Merged

Period 29073 #29159

merged 6 commits into from
Oct 23, 2019

Conversation

HughKelley
Copy link
Contributor

@HughKelley HughKelley closed this Oct 22, 2019
@HughKelley
Copy link
Contributor Author

HughKelley commented Oct 22, 2019

One of the CI checks failed so I closed and was going to work back through it but looking at the checks for recent commits to Master this might be a Travis issue so reopening.

@HughKelley HughKelley reopened this Oct 22, 2019
@gfyoung gfyoung added Docs Period Period data type labels Oct 22, 2019
@WillAyd
Copy link
Member

WillAyd commented Oct 22, 2019

Looks like the failure is trailing whitespace on line 1781

@HughKelley
Copy link
Contributor Author

hmm thanks, fixed. Initially the check that failed was that Travis timed out while compiling.

Is it normal for commits to master to be showing CI check fails? When i saw that, I assumed there was something going on and that I should just try again later.

@jbrockmendel
Copy link
Member

Is it normal for commits to master to be showing CI check fails? When i saw that, I assumed there was something going on and that I should just try again later.

We recently added a Travis build for python3.8 and it is timing out annoyingly often. Just re-started that, so hopefully it will resolve itself.

@WillAyd WillAyd added this to the 1.0 milestone Oct 23, 2019
@WillAyd WillAyd merged commit af1585d into pandas-dev:master Oct 23, 2019
@WillAyd
Copy link
Member

WillAyd commented Oct 23, 2019

Great thanks @HughKelley

HawkinsBA pushed a commit to HawkinsBA/pandas that referenced this pull request Oct 29, 2019
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
@HughKelley HughKelley deleted the period_29073 branch January 6, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Period Period data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOCS: Errors PR08 PR09 in pandas.Period
4 participants